Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children inside table cell have reversed order #335

Closed
robmadole opened this issue Apr 8, 2020 · 6 comments
Closed

Children inside table cell have reversed order #335

robmadole opened this issue Apr 8, 2020 · 6 comments
Assignees
Labels

Comments

@robmadole
Copy link

With the following:

| What              |
| ----------------- |
| This part is fine |
| This is `broken`  |

Passing this through Earmark.as_html!/1 results in the This is and broken being reversed in order:

      <td style="text-align: left;">
<code class="inline">broken</code>        This is 
      </td>

It looks like Earmark.as_ast is actually the culprit. I was able to git bisect it to 9127d91.

@RobertDober
Copy link
Collaborator

RobertDober commented Apr 12, 2020

Yoda talk, what's wrong with that? 😉
However not everybody likes Star Wars, so we'll fix that.

On a side note, you are not reporting this bug against the released version so in general I would need to know where it occurred, however you got lucky on this one as I am already aware of the problem

Bisect link above, very nice indeed, sorry for complaining 😊

Thank you for reporting this, and you are absolutely right, the AST parser gets some Enum.reverse wrong still...

@RobertDober RobertDober self-assigned this Apr 12, 2020
@RobertDober RobertDober added this to the 1.5 milestone Apr 12, 2020
@robmadole
Copy link
Author

@RobertDober thanks for taking a look. At first, a feature I thought this was but that is the path to the Dark Side...so report this I must. 😉

And no worries on the release version comment. The reason I ran into this is because I reached for the AST parser to do some Dark Side mind manipulation converting a to router-link in a Vue app. I think the bug exists in the AST parser pretty far back.

@RobertDober
Copy link
Collaborator

... since the beginning and it is one of some road blockers for 1.5 where the AST will become official API, but I guess you know all that.

@leandrocp
Copy link

I believe I came to the same bug here elixir-ecto/ecto_sql#231 (comment), I'm leaving this comment in case it helps and also to be notified so I can help testing a fix.

@RobertDober RobertDober modified the milestones: 1.5, 1.4.6 Jun 14, 2020
RobertDober added a commit that referenced this issue Jun 19, 2020
@robmadole
Copy link
Author

Excellent! Getting excited for the 1.5 milestone.

@RobertDober
Copy link
Collaborator

1.4.6 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants