Fix elixir 1.5 compile warnings #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanx a lot @joshuawscott |
|
Sorry if you thought I was patronizing you, that was not at all what I was saying. I only made the change to silence the compiler warning. I would also personally prefer Enum.filter_map, but 🤷♂️ what can you do? |
|
ooops I was too whiney. The compiler is patronizing me not you. I am very thankful for doing these necessary work for us. |
|
BTW just installed 1.5.0 Compile and Test without a single warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy!
Mostly just replacing
strip/lstrip/rstrip/to_char_listwith the newer versions to fix Elixir 1.5 compile warnings. Also convertEnum.filter_map/3to a list comprehension for the same reason.