Treat <del> tag (used for strikethrough text) as a compact tag #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, ty, I will merge this as soon as I have time to fix the failing doctest, if you happen to have time to do it yourself, ... do not hesitate 👍 But thank you in any case. |
|
Wooow that was fast, funny message, push crossing here. |
|
No problem and thanks for Earmark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
The
<del>tag, which is used to render~~strikethrough text~~, is currently rendered using this defintion of_to_html/4. Unfortunately, this results in a newline being output before the closing tag and so the strikethrough effect is longer than it should be.Before the fix
After the fix