Some small improvements #45
Conversation
RSDuck
commented
Mar 18, 2017
RSDuck
commented
- Refixed Incorrect indentation after string literal #32
- Added support for auto bracket closing in nimble files
- Improved the identation pattern to work on statement macros
| ["[", "]"], | ||
| ["(", ")"] | ||
| ], | ||
| "autoClosingPairs": [ |
There was a problem hiding this comment.
I dont sure that this is good idea to use json configuration together with code based in nimMain.ts, also autoClosingPairs is marked as Deprecated in https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2786
May be it will more reasonable use declaration in code for better type safety?
There was a problem hiding this comment.
Is it really deprecated if it's inside a json configuration? Because the source code states:
/**
* **Deprecated** Do not use.
*
* @deprecated * Use the the autoClosingPairs property in the language configuration file instead.
*/That's the reason why I created a json language config file anyway. And here in the official manual they still recommend autoClosingPairs in json configs. Also e.g. the Python extension(integrated into VSCode) depends on autoClosingPairs, otherwise they would have the same problem.
