Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented the elrpc client #48

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Reimplemented the elrpc client #48

merged 2 commits into from
Apr 19, 2017

Conversation

RSDuck
Copy link
Contributor

@RSDuck RSDuck commented Apr 15, 2017

Originally I wanted to improve the elrpc and the elparser library but then I thought screw it. The procol is so simple, in the time, I would need to find the cause for the lag spikes, I could also rewrite the library. And that's what I've done. It acts as a complete replacement and hasn't got these weired lag spikes and is less code.

I only tested it with nimsuggest from devel on Windows, so there might be some problems, but I think there aren't. In the files I've created, I changed the copyright notice to Xored Software Inc., RSDuck. I hope this is ok.

In the signature provider I removed the - 1 before the column. Otherwise the signature provider wouldn't work on devel nimsuggest(and future releases). I don't know if it still works with stable Nim, otherwise I would wait until Nim 0.17 with merging this pull request or making a new release of the extension. And as the last change I added support for code blocks in documentary comments.

@kosz78
Copy link
Collaborator

kosz78 commented Apr 17, 2017

Great, thank you for your contribution
According backward compatibility you can use isNimSuggestVersion for nimsuggest version check

@RSDuck
Copy link
Contributor Author

RSDuck commented Apr 18, 2017

I did some checks, all changes work flawlessly with latest stable Nim, so that's not a problem

@kosz78 kosz78 merged commit 367c0a9 into pragmagic:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants