Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I wanted to improve the elrpc and the elparser library but then I thought screw it. The procol is so simple, in the time, I would need to find the cause for the lag spikes, I could also rewrite the library. And that's what I've done. It acts as a complete replacement and hasn't got these weired lag spikes and is less code.
I only tested it with nimsuggest from devel on Windows, so there might be some problems, but I think there aren't. In the files I've created, I changed the copyright notice to Xored Software Inc., RSDuck. I hope this is ok.
In the signature provider I removed the
- 1
before the column. Otherwise the signature provider wouldn't work on devel nimsuggest(and future releases). I don't know if it still works with stable Nim, otherwise I would wait until Nim 0.17 with merging this pull request or making a new release of the extension. And as the last change I added support for code blocks in documentary comments.