Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AccountController.cls #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AccountController.cls #9

wants to merge 1 commit into from

Conversation

prakash-purswani
Copy link
Owner

@prakash-purswani prakash-purswani commented Nov 30, 2023

Note

Please fill the below checklist as per the contents of the Pull Request.
Mark "Not Applicable" as needed.

Key Information

Deliverable Name (Enter JIRA Story Numbers - comma separated):

Deliverable Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Deliverable Complexity

  • LOW
  • MEDIUM
  • HIGH

Testing

  • Unit testing document is attached.
  • Positive / Negative testing done.
  • Not Applicable

Additional comments:

Configuration

  • Sanofi Naming conventions and best practices followed for Fields/Objects/Flows/Validation Rules, etc. - (LINK TO BE ADDED)
  • Profiles do not include any FLS or CRUD permissions, most of the permissions are part of the Permission Sets.
  • Description is added for all components.
  • Validation Rules: Bypass logic has been added in Validation Rules.
  • Flows: Entry criteria filters irrelevant records.
  • Flows: Bypass logic is added in the entry criteria.
  • Flows: Best practices are followed - Reference
  • Not Applicable

Additional comments:

Apex

  • Sanofi Naming conventions followed for Apex Classes, Apex Triggers, etc.
  • Code comments and change log as per the Apex Java Doc format.
  • Best practices are followed to handle Governor limits.
  • Trigger Framework has been used wherever applicable.
  • Coding standards are followed as per Sanofi guidelines - (LINK TO BE ADDED)
  • Exception handling and Logging has been implemented.
  • Security best practices are followed to control data visibility.
  • Not Applicable

Additional comments:

LWC

  • Sanofi Naming conventions followed for Component Names and other metadata.
  • LWC performance best practices are followed - Reference
  • LWC config file reviewed for correct targets.
  • Description is added for all components.
  • Not Applicable

Additional comments:

Integration

  • Named Credential is used for Endpoint and other information.
  • No hard-coded URLs or credentials in the code.
  • Request and Responses are logged using the logging framework.
  • Exception handling and Logging has been implemented.
  • Necessary Framework classes are used for REST callouts and Platform Event publishing.
  • Not Applicable

Additional comments:

Omniscript

  • To be added later
  • Not Applicable

Additional comments:

Security

  • No PII/PHI data in the code
  • More to be added
  • Not Applicable

Additional comments:

Code scan

  • SonarQube Static Code analysis is successful without any critical/high category issues.

Additional comments:

Review Bypassed

  • I approve to bypass the review.

Warning

Bypassing the review process should be done only in valid cases with proper justification.

Justification

  • HotFix / Incident Fix
  • Non-Technical change
  • DevOps configuration
  • Other (please add the justification in comments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant