-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: VSCode colors now sync with changing theme. #1608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add this type because everyone does not use the ext Dev mod option because this option enables to use single windows not open multiple windows so that's why don't added this type
Everyone approving this, Did you guys tried multi window vscode with this? |
Hey so I found out that if I modify the code binary file to: #!/bin/bash
set -euo pipefail
flags_file="${XDG_CONFIG_HOME:-$HOME/.config}/code-flags.conf"
declare -a codeflags
if [[ -f "${flags_file}" ]]; then
mapfile -t < "${flags_file}" CODEMAPFILE
fi
for line in "${CODEMAPFILE[@]}"; do
if [[ ! "${line}" =~ ^[[:space:]]*#.* ]]; then
codeflags+=("${line}")
fi
done
name=electron29
flags_file="${XDG_CONFIG_HOME:-$HOME/.config}/${name}-flags.conf"
declare -a electronflags
if [[ -f "${flags_file}" ]]; then
mapfile -t < "${flags_file}" ELECTRONMAPFILE
fi
for line in "${ELECTRONMAPFILE[@]}"; do
if [[ ! "${line}" =~ ^[[:space:]]*#.* ]]; then
electronflags+=("${line}")
fi
done
if pgrep -f "/usr/lib/${name}/electron" > /dev/null; then
ELECTRON_RUN_AS_NODE=1 exec /usr/lib/${name}/electron /usr/lib/code/out/cli.js /usr/lib/code/code.js "$@"
else
ELECTRON_RUN_AS_NODE=1 exec /usr/lib/${name}/electron /usr/lib/code/out/cli.js "${electronflags[@]}" /usr/lib/code/code.js ${codeflags[@]} "$@"
fi Multiwindow works
|
@kRHYME7 the above comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Pull Request
Description
Type of change
Please put an
x
in the boxes that apply:Checklist
Please put an
x
in the boxes that apply: