Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent onSelected callback from being called at initialization #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bryanchow
Copy link

I believe this fixes issue #10. Comments welcome. Cheers!

@prashantchaudhary
Copy link
Owner

Nice! I looked at your code and it does seem to have solved the problem but the request can't be automatically merged. Can you try merging your request again?

@bryanchow
Copy link
Author

There is a conflict with Ilya Verbitskiy's ff84358, which looks like it was written after my commits. I will rebase my branch later today.

@prashantchaudhary
Copy link
Owner

Thanks Bryan!

On 07-Feb-2013, at 10:53 PM, Bryan Chow notifications@github.com wrote:

There is a conflict with Ilya Verbitskiy's ff84358, which looks like it was written after my commits. I will rebase my branch later today.


Reply to this email directly or view it on GitHub.

@gordonbisnor
Copy link

What happened to this pull request?

@zoghal
Copy link

zoghal commented Apr 20, 2013

👍

@andreapavoni
Copy link

so, why this patch is still not merged? how it's supposed to be used a plugin like this, if I can't associate actions on select, WHILE non triggering the "selected" event at load-time? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants