Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3 support #1

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Add Python 3 support #1

merged 2 commits into from
Apr 6, 2023

Conversation

prashantsengar-cl
Copy link
Owner

  • builtins is not a dict
  • Initialize imports at level=0

@prashantsengar-cl
Fix: __builtins__ is not a dict
cb707ea 
__builtins__ is not a dict. Hence getting and setting attributes using getattr and setattr respectively
@prashantsengar-cl
Initialize imports at level=0
0b42174 
In Python 3, min level of imports is 0. It fails at -1 with error:

```
ValueError: level must be >= 0
```

__builtins__ is not a dict. Hence getting and setting attributes using getattr and setattr respectively
@prashantsengar-cl
Copy link
Owner Author

Tested multiple times locally

@prashantsengar-cl prashantsengar-cl merged commit 668e039 into master Apr 6, 2023
@prashantsengar-cl prashantsengar-cl deleted the add_python_3_support branch April 6, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prashantsengar-cl