GDV-95:[C++]Match gandiva mod operator to dremio for mod zero. (apach…

…e#74) * Temporarily matching what the dremio does for mod zero. * Used the latest Arrow APIs for allocating buffers.
praveenbingo · Sep 10, 2018 · 495956a · 495956a
1 parent 21c9d8b
commit 495956a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/cpp/src/gandiva/codegen/projector.cc b/cpp/src/gandiva/codegen/projector.cc
@@ -148,14 +148,15 @@ Status Projector::AllocArrayData(const DataTypePtr &type, int num_records,
   }
 
   arrow::Status astatus;
-  auto null_bitmap = std::make_shared<arrow::PoolBuffer>(pool_);
-  astatus = null_bitmap->Resize(arrow::BitUtil::BytesForBits(num_records));
+  std::shared_ptr<arrow::ResizableBuffer> null_bitmap;
+  int64_t size = arrow::BitUtil::BytesForBits(num_records);
+  astatus = arrow::AllocateResizableBuffer(pool_, size, &null_bitmap);
   GANDIVA_RETURN_ARROW_NOT_OK(astatus);
 
-  auto data = std::make_shared<arrow::PoolBuffer>(pool_);
+  std::shared_ptr<arrow::ResizableBuffer> data;
   const auto &fw_type = dynamic_cast<const arrow::FixedWidthType &>(*type);
   int64_t data_len = arrow::BitUtil::BytesForBits(num_records * fw_type.bit_width());
-  astatus = data->Resize(data_len);
+  astatus = arrow::AllocateResizableBuffer(pool_, data_len, &data);
   GANDIVA_RETURN_ARROW_NOT_OK(astatus);
 
   *array_data = arrow::ArrayData::Make(type, num_records, {null_bitmap, data});

diff --git a/cpp/src/gandiva/precompiled/arithmetic_ops.cc b/cpp/src/gandiva/precompiled/arithmetic_ops.cc
@@ -44,10 +44,10 @@ extern "C" {
   DATE_TYPES(INNER, NAME, OP)                    \
   INNER(NAME, boolean, OP)
 
-#define BINARY_GENERIC_OP(NAME, IN_TYPE1, IN_TYPE2, OUT_TYPE, OP)          \
+#define MOD_OP(NAME, IN_TYPE1, IN_TYPE2, OUT_TYPE)                         \
   FORCE_INLINE                                                             \
   OUT_TYPE NAME##_##IN_TYPE1##_##IN_TYPE2(IN_TYPE1 left, IN_TYPE2 right) { \
-    return left OP right;                                                  \
+    return (right == 0 ? left : left % right);                             \
   }
 
 // Symmetric binary fns : left, right params and return type are same.
@@ -60,8 +60,8 @@ NUMERIC_TYPES(BINARY_SYMMETRIC, subtract, -)
 NUMERIC_TYPES(BINARY_SYMMETRIC, multiply, *)
 NUMERIC_TYPES(BINARY_SYMMETRIC, divide, /)
 
-BINARY_GENERIC_OP(mod, int64, int32, int32, %)
-BINARY_GENERIC_OP(mod, int64, int64, int64, %)
+MOD_OP(mod, int64, int32, int32)
+MOD_OP(mod, int64, int64, int64)
 
 // Relational binary fns : left, right params are same, return is bool.
 #define BINARY_RELATIONAL(NAME, TYPE, OP) \

diff --git a/cpp/src/gandiva/precompiled/arithmetic_ops_test.cc b/cpp/src/gandiva/precompiled/arithmetic_ops_test.cc
@@ -33,4 +33,6 @@ TEST(TestArithmeticOps, TestIsDistinctFrom) {
   EXPECT_EQ(is_not_distinct_from_int32_int32(1000, true, 1000, true), true);
 }
 
+TEST(TestArithmeticOps, TestMod) { EXPECT_EQ(mod_int64_int32(10, 0), 10); }
+
 }  // namespace gandiva
diff --git a/cpp/src/gandiva/precompiled/types.h b/cpp/src/gandiva/precompiled/types.h
@@ -117,6 +117,8 @@ int64 date_trunc_Week_timestamp(timestamp);
 
 int32 mem_compare(const char *left, int32 left_len, const char *right, int32 right_len);
 
+int32 mod_int64_int32(int64 left, int32 right);
+
 }  // extern "C"
 
 #endif  // PRECOMPILED_TYPES_H