Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Docusaurus 3.0.0 #124

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add support for Docusaurus 3.0.0 #124

merged 2 commits into from
Nov 10, 2023

Conversation

Hinton
Copy link
Contributor

@Hinton Hinton commented Oct 30, 2023

This adds support for Docusaurus 3.0.0 by expanding the peer dependencies.

Resolves #123

@QuintenQVD0
Copy link

Please merge this, we need this!

@wgruszczyk
Copy link

@Hinton After migrating to 3.3.0 I get a lot issues alike:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'title') at a.getTitleHit (271.d685c5ef.js:1:811) at 271.d685c5ef.js:1:2166 at Array.forEach (<anonymous>) at 271.d685c5ef.js:1:1985 at new Promise (<anonymous>) at a.search (271.d685c5

Did you experience the same? Maybe you can suggest a workaround?
Thx!

@wgruszczyk
Copy link

OK, nevermind. I had a swizzled version of the search component. Removed it and it works like a charm. Thx!

@windhamdavid
Copy link

@wgruszczyk - just wanted to add some additional context here to make it a bit more discoverable and easy to fix.

  • If you previously swizzle'd a SearchBar in a prior version <= v.2.2:
foo@bar:~$ npm run swizzle docusaurus-lunr-search SearchBar -- --danger
  • You need to eject it before your build for >= v.3.0:
foo@bar:~$ npm run swizzle docusaurus-lunr-search SearchBar -- --eject

Thanks for the effort @Hinton & @praveenn77 👊🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support docusaurus 3
5 participants