Avoid adding extra / on hits
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say we got doc.url = /docs/intro.html with baseUrl = '/', the condition failed because doc.url starts with a `/`, so we returned `doc.url with baseUrl = `/some-thing/`, the condition succeeds because baseUrl is not `/`, so we return the concatenated url, but it's wrong. it gives: `/some-thing//docs/intro.html` The thing is that the doc.url already contains the baseUrl, so there is no need to concatenate.
|
@praveenn77 & @daddykotex - I can confirm this base URL issue with v2.3.1 & Docusaurus v2.2.0. ( edit: and I just rebuilt to test. I'm getting
|
windhamdavid
added a commit
to windhamdavid/til
that referenced
this pull request
Nov 13, 2022
windhamdavid
added a commit
to windhamdavid/til
that referenced
this pull request
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
say we got doc.url = /docs/intro.html
with baseUrl = '/', the condition failed because doc.url starts with a
/, so we returned `doc.urlwith baseUrl =
/some-thing/, the condition succeeds because baseUrl is not/, so we return the concatenated url, but it's wrong. it gives:/some-thing//docs/intro.htmlThe thing is that the doc.url already contains the baseUrl, so there is no need to concatenate.
Again running off the docusaurus getting started and applying the fix locally:
baseUrl = /:baseUrl = /some-thing/:This is a follow up to #89 and #88