Issue-180: Add disable finalizer config #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 80.36% 80.36%
=======================================
Files 10 10
Lines 1839 1839
=======================================
Hits 1478 1478
Misses 281 281
Partials 80 80
Continue to review full report at Codecov.
|
Signed-off-by: Aaron <aaron.wu@dell.com>
realAaronWu
force-pushed
the
add-disable-finalizer-config
branch
from
31562fb
to
3df8176
Compare
| @@ -72,6 +73,10 @@ func main() { | |||
| log.Warn("----- Running in test mode. Make sure you are NOT in production -----") | |||
| } | |||
|
|
|||
| if controllerconfig.DisableFinalizer { | |||
| log.Warn("----- Running with finalizer disabled. -----") | |||
| } | |||
There was a problem hiding this comment.
Good idea. We probably should do that on the other operators to avoid confusion for anybody debugging issues in future.
maddisondavid
approved these changes
Oct 19, 2021
Co-authored-by: David Maddison <maddisondavid@gmail.com> Signed-off-by: Shi, Crane <crane.shi@emc.com>
CraneShiEMC
force-pushed
the
add-disable-finalizer-config
branch
from
3ba8dca
to
bc698fc
Compare
|
@CraneShiEMC looks like PR is forked from a wrong repo, Could you please correct it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
add DisableFinalizer config and skip adding zkFinalziers when set it to true.
Purpose of the change
Fixes #180
What the code does
skip adding zkFinalziers when DisableFinalizer set to true.
How to verify it
Set disableFinalizer to true in values and deploy Bookkeeper operator, the deployed Bookkeeper clusters should have the finalizers as empty.