changes for controller runtime upgrade #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 86.77% 86.31% -0.46%
==========================================
Files 9 9
Lines 1474 1542 +68
==========================================
+ Hits 1279 1331 +52
- Misses 138 153 +15
- Partials 57 58 +1
Continue to review full report at Codecov.
|
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Signed-off-by: anisha.kj <anisha.kj@dell.com>
anishakj
force-pushed
the
issue-controller-runtime
branch
from
803a041
to
9a12e1b
Compare
anishakj
changed the title
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Prabhaker24
approved these changes
Sep 13, 2020
SrishT
requested changes
Sep 14, 2020
| - name: webhook-cert | ||
| secret: | ||
| {{- if .Values.webhookCert.generate }} | ||
| secretName: {{ template "bookkeeper-operator.fullname" . }}-cert-tls |
There was a problem hiding this comment.
Name of the secret should be {{ template "bookkeeper-operator.fullname" . }}-cert-tls-bk
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Signed-off-by: anisha.kj <anisha.kj@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anisha.kj anisha.kj@dell.com
Change log description
Update controller run time to 0.5.2 and operator-sdk to v0.17.0
Purpose of the change
Fixes #69
What the code does
With controller run time upgrade, webhook validation mechanism changes. We have to create webhook svc, Also for validation a certificate needs to be installed.
How to verify it