Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 241: Reorg code #248

Merged
merged 14 commits into from
May 11, 2021
Merged

Issue 241: Reorg code #248

merged 14 commits into from
May 11, 2021

Conversation

Tristan1900
Copy link
Member

@Tristan1900 Tristan1900 commented Apr 26, 2021

Change log description
Reorg the code.

  • Move internal file raw_client, segment_metadata, segment_selector, reactor, segment_writer to a new module segment and remove segment prefix in their names.
  • Move event_stream_writer, event_reader , reader_group related files and transaction module into a new module 'event'.
  • Move bytestream to a new module byte.
  • Move synchronizer, tablemap to a new module sync.
  • Move trace, metric to a new module util.
  • Delete error file and move individual error into related files.
  • Rename event_stream_writer to event_writer.
  • Rename transactional_event_stream_writer to transaction_event_writer.
  • Rename byte_stream_writer and byte_stream_reader to byte_writer and byte_reader.
  • Rename table_synchronizer to synchronizer.

Purpose of the change
Fix #241 #246 #240

What the code does

How to verify it
Tests should pass

Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Wenqi Mou added 3 commits April 27, 2021 00:40
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
@Tristan1900 Tristan1900 marked this pull request as ready for review April 29, 2021 15:44
Wenqi Mou added 5 commits May 3, 2021 16:34
fix
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
src/event/reader_group.rs Outdated Show resolved Hide resolved
src/event/reader_group.rs Outdated Show resolved Hide resolved
Wenqi Mou added 4 commits May 10, 2021 10:44
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #248 (b621efa) into master (94a4351) will decrease coverage by 0.81%.
The diff coverage is 81.20%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   78.38%   77.57%   -0.82%     
==========================================
  Files          51       44       -7     
  Lines       10541    10323     -218     
==========================================
- Hits         8263     8008     -255     
- Misses       2278     2315      +37     
Impacted Files Coverage Δ
config/src/lib.rs 58.33% <ø> (-39.02%) ⬇️
controller-client/src/mock_controller.rs 44.98% <ø> (ø)
src/event/writer.rs 100.00% <ø> (ø)
src/lib.rs 100.00% <ø> (+3.33%) ⬆️
wire_protocol/src/lib.rs 100.00% <ø> (ø)
src/segment/raw_client.rs 78.35% <21.42%> (ø)
shared/src/lib.rs 87.24% <25.00%> (-0.87%) ⬇️
src/segment/event.rs 50.00% <50.00%> (ø)
src/segment/writer.rs 83.84% <57.89%> (ø)
src/event/reader.rs 74.30% <75.42%> (ø)
... and 32 more

Signed-off-by: Wenqi Mou <wenqi.mou@dell.com>
@shrids shrids merged commit e6ed8c1 into master May 11, 2021
@Tristan1900 Tristan1900 deleted the reorg branch May 11, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module reorganization
4 participants