-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 354: Nodejs StreamManager #355
Issue 354: Nodejs StreamManager #355
Conversation
Signed-off-by: thekingofcity <3353040+thekingofcity@users.noreply.github.com>
If this is merged, the Supported APIs may be updated to this.
|
@@ -0,0 +1,460 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to check in the package lock? Or would it be better for this to be excluded and autogenerated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.json
should be committed and is suggested by the npm
official doc.
https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json
This file is intended to be committed into source repositories, and serves various purposes:
npm ci
will use the versions in package-lock.json
and produces a deterministic build.
This may change if we release platform-specific builds as different platforms need different packages versions.
Signed-off-by: thekingofcity <3353040+thekingofcity@users.noreply.github.com>
Signed-off-by: thekingofcity <3353040+thekingofcity@users.noreply.github.com>
Signed-off-by: thekingofcity <3353040+thekingofcity@users.noreply.github.com>
Signed-off-by: thekingofcity 3353040+thekingofcity@users.noreply.github.com
Change log description
Add
StreamManager
support to Nodejs bindings.Purpose of the change
Fixes #354
What the code does
Use
neon-bindings
to wrap the rust client.How to verify it
npm i
npm run build-debug
node --loader ts-node/esm tests/stream_manager.ts
should pass in a clean Pravega standalone deployment.