Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #25: Switch to Bincode2 #36

Merged
merged 38 commits into from
Jan 22, 2020
Merged

Issue #25: Switch to Bincode2 #36

merged 38 commits into from
Jan 22, 2020

Conversation

tkaitchuck
Copy link
Member

Change log description

  • Moves over to bincode2 to avoid the need for JavaString instances.

Purpose of the change
Fixes #35 . Also incidentally fixes #34 .

What the code does
Uses bincode2's config rather than a custom type for serialization/deserialization.
Adds backtraces to errors.

tkaitchuck and others added 30 commits December 19, 2019 17:10
@tkaitchuck
Move some files around
685f522
@tkaitchuck
Move main method for controller
da97390
@tkaitchuck
Upgrade versions and orginize deps
0ac4546
@tkaitchuck
Adapt tests/docs to new tokio version
8b16a0e
@tkaitchuck
Move controller-client into a its own crate
42a803d
@tkaitchuck
Fix docs examples
6967b81
@tkaitchuck
Add comment
3b243eb
@tkaitchuck
formating
e201118
save the change
8e2ddbc
develop serialize error
b9f9f5d
@tkaitchuck
Merge branch 'master' of github.com:pravega/pravega-client-rust
a8dd0b8
finish serialize error handling
a5186db
add deserialize error handling
7cc11e5
add deserialize error handling and fix fmt error
08a25fb
change snafu description
5954d01
Merge branch 'master' into issue-15-error-handling
7647885
fix conflict
1e8c0a5
@tkaitchuck
Add additional lints from clippy. (and fix some hilighted problems)
d500acc
@tkaitchuck
Merge branch 'master' of github.com:pravega/pravega-client-rust into …
916f210 
…clippy
@tkaitchuck
Merge branch 'master' into issue-15-error-handling
867eb40
@tkaitchuck
Avoid some clippy warnings
6d75581
@tkaitchuck
Avoid calling expect when not needed.
3d99e4e
@tkaitchuck
Remove more unneeded error cases.
d4a8302 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
More idomatic way to allocate an array of zeros.
b795313 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Create local variable
3890e3b 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Merge branch 'issue-15-error-handling' of github.com:pravega/pravega-…
6c9de97 
…client-rust into clippy

� Conflicts:
�	src/wire_protocol/commands.rs
�	src/wire_protocol/wire_commands.rs
@tkaitchuck
Propigate errors properly
9fad598 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Add some additional information for Cargo
eb29d50 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Enable clippy checks on our PRs
86c21a8 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Remove redundant licence declaration
2f77e87 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
tkaitchuck and others added 7 commits January 10, 2020 18:12
@tkaitchuck
Disallow unsafe code
cf537d1 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Merge branch 'master' into clippy
efc8d6c
@tkaitchuck
Add output dir to gitignore
796c126 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Switch to bincode
f3d6085 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Use results in unit tests.
01dffeb 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Remove JavaString and use Bincode2's custom length.
76172bc 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck
Add backtraces to errors.
b719c2e 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
zwx14700
zwx14700 approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@zwx14700 zwx14700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great change.

shrids
shrids approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@shrids shrids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shrids
Copy link
Contributor

shrids commented Jan 22, 2020

Observing that the rust file auto generated from the Controller.proto is not being built with the new change.

error[E0277]: the trait bound `controller::StreamInfo: prost::message::Message` is not satisfied
    --> /home/osboxes/code/master/pravega-client-rust/target/debug/build/pravega-controller-client-3df4ddb1cd436cfb/out/io.pravega.controller.stream.api.grpc.v1.rs:1095:28306
 = note: required because of the requirements on the impl of `tonic::codec::Codec` for `tonic::codec::prost::ProstCodec<controller::DelegationToken, controller::StreamInfo>`

@shrids shrids merged commit 955b172 into master Jan 22, 2020
@shrids shrids deleted the bincode2 branch January 22, 2020 05:54
@tkaitchuck
Copy link
Member Author

@shrids I don't thinks this is on us, we upgraded a version: hyperium/tonic#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrids shrids shrids approved these changes

@zwx14700 zwx14700 zwx14700 approved these changes

Assignees

@shrids shrids

@zwx14700 zwx14700

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Depend on bincode2 Add backtraces to errors
3 participants
@tkaitchuck @shrids @zwx14700