Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 10: Update cluster status #123

Merged
merged 35 commits into from
Feb 6, 2019
Merged

Issue 10: Update cluster status #123

merged 35 commits into from
Feb 6, 2019

Conversation

Tristan1900
Copy link
Member

@Tristan1900 Tristan1900 commented Jan 28, 2019 •
edited
Loading

Change log description

  • Add Conditions to Pravega cluster status.
  • When cluster is ready, the PodsReady state will be set

Purpose of the change

Fix #10

How to test the change

Tests should pass

Signed-off-by: wenqi Wenqi.Mou@emc.com

Update cluster status
0de3d76 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
wenqi added 2 commits January 28, 2019 14:36
Add test for issue 10
9aa20d0 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Fix travis
7357786 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
@adrianmo adrianmo changed the title Update cluster status Issue 10: Update cluster status Jan 29, 2019
@adrianmo adrianmo added status/work-in-progress PR work is in progress; do not merge area/API Issue related to the custom resource API labels Jan 29, 2019
adrianmo
adrianmo suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tristan1900 please have a look at my comment in the issue: #10 (comment)

wenqi added 2 commits January 30, 2019 20:59
Add condition to Pravega cluster resource
1e36be5 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
fix test and fix condition logic
74d535a 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
adrianmo
adrianmo suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tristan1900 good job with the new status design. I've added a couple of comments inline. Also, it'd be good to have unit tests for the new status.go file.

pkg/apis/pravega/v1alpha1/status.go Outdated Show resolved Hide resolved
pkg/apis/pravega/v1alpha1/status.go Outdated Show resolved Hide resolved
pkg/apis/pravega/v1alpha1/status.go Show resolved Hide resolved
pkg/controller/pravegacluster/pravegacluster_controller.go Outdated Show resolved Hide resolved
wenqi and others added 4 commits January 31, 2019 16:16
Modify conditions logic
f0c2a1b 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Add unit test and fix some bugs
27cadad 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Fix unit test
5d36328 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
@adrianmo
Change the Status spec, controller logic, update to sdk 0.4.0
5c9f39a 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
wenqi and others added 9 commits February 3, 2019 20:46
Fix crd bug
d71dcf8 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Fix test error
d7a553a 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Fix test bug
cc986d4 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
fix test again
6329c02 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
increase travis timeout
ad462fe 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
@adrianmo
Update CR spec only if default values have been applied
1c97a01 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Merge branch 'issue-10-update-cluster-status' of github.com:pravega/p…
91647b0 
…ravega-operator into issue-10-update-cluster-status

* 'issue-10-update-cluster-status' of github.com:pravega/pravega-operator:
  increase travis timeout
@adrianmo
Update status conditions
413ad8e 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
fix unit test and travis crd
5888fc6 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
update k8s version
384d5ac 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
try 0.29 and 1.11.0
ee74208 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
wenqi and others added 12 commits February 4, 2019 23:55
try 1.12 and 0.30
f325e0f 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
@adrianmo
Use Ubuntu as Travis base OS
97b5134 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Bump minikube version
29a6965 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Update Travis steps
1caec7e 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Install socat
ed9b67e 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Update Travis steps
9a0207c 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Replace ZK deprecated 'size' field by 'replicas'
937584b 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Update e2e tests
530881f 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Remove Travis wait wrapper
ba92671 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Remove go test timeout
a05d78b 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Minor adjustments
2cba0c2 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo
Move Travis dependency versions to envvars
fa84c60 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
adrianmo
adrianmo suggested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LastTransitionTime and LastUpdateTime are never set.
  • Increase coverage on status.go

@adrianmo
Fix status.go tests
81faf61 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@Tristan1900
Copy link
Member Author

LGTM! Thanks for the hard work!

adrianmo and others added 2 commits February 5, 2019 19:18
@adrianmo
Fix e2e tests
99d32e1 
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
Minor adjustment
f997e4a 
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
@adrianmo adrianmo merged commit 3ab0f66 into master Feb 6, 2019
@adrianmo adrianmo deleted the issue-10-update-cluster-status branch February 6, 2019 07:14
adrianmo added a commit that referenced this pull request Feb 6, 2019
@adrianmo
Merge branch 'master' into issue-81-upgrade-feature
6711ced 
* master:
  Issue 10: Update cluster status (#123)
@adrianmo
Copy link
Contributor

adrianmo commented Feb 6, 2019

Operator: Provide CR status information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmo adrianmo adrianmo approved these changes

Assignees

@Tristan1900 Tristan1900

Labels
area/API Issue related to the custom resource API status/work-in-progress PR work is in progress; do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tristan1900 @adrianmo