Fix Pravega and BookKeeper Java options #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
This was referenced Mar 25, 2019
Tristan1900
reviewed
Mar 25, 2019
Tristan1900
reviewed
Mar 25, 2019
Tristan1900
reviewed
Mar 25, 2019
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
Tristan1900
approved these changes
Mar 26, 2019
|
Got @vedanthh confirmation in #141 (comment) |
This was referenced Mar 29, 2019
adrianmo
added a commit
that referenced
this pull request
Mar 29, 2019
* master: Fix Pravega and BookKeeper Java options (#145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
BOOKIE_MEM_OPTS,BOOKIE_GC_OPTS, andBOOKIE_GC_LOGGING_OPTSenvironment variables instead ofBK_BOOKIE_EXTRA_OPTS.Purpose of the change
Fix #144
Related to #141
How to test the change
After deploying a Pravega cluster,
kubectl execinto the containers, list the processes withps aux, and check that Java options are properly passed to the Java process.Signed-off-by: Adrián Moreno adrian@morenomartinez.com