Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 163: Create Helm chart to install Pravega #165

Merged
merged 10 commits into from
Apr 29, 2019
Merged

Conversation

adrianmo
Copy link
Contributor

@adrianmo adrianmo commented Apr 17, 2019

Change log description

  • Update existing pravega-operator Helm chart
  • Add documentation for pravega-operator chart
  • Add tests for pravega-operator chart
  • Create a pravega Helm chart to install a Pravega cluster with initial set of configuration parameters
  • Add documentation for pravega chart
  • Add tests for pravega charts

Purpose of the change

How to test the change

  • Follow the instructions in the charts directory to install and check that the charts works as expected
  • Tests should pass

Signed-off-by: Adrián Moreno adrian@morenomartinez.com

Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo changed the title Create Helm chart to install Pravega Issue 163: Create Helm chart to install Pravega Apr 17, 2019
@adrianmo adrianmo added kind/task Task not directly related to a feature status/work-in-progress PR work is in progress; do not merge labels Apr 17, 2019
wenqi added 4 commits April 17, 2019 14:41
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Copy link
Contributor Author

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tristan1900 Since the Terratest is only a dependency for testing charts, and not for the operator itself, I was thinking that we might want to keep it out of the Gopkg.toml and avoid including these 3M+ new files into the vendor dir.

We can create a make command to install it and run the chart tests.

What do you think?

charts/pravega-operator/templates/operator.yaml Outdated Show resolved Hide resolved
@Tristan1900
Copy link
Member

@adrianmo Great suggestion! Will do that.

Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrián Moreno <adrian@morenomartinez.com>
@adrianmo adrianmo added status/ready The issue is ready to be worked on; or the PR is ready to review and removed status/work-in-progress PR work is in progress; do not merge labels Apr 29, 2019
@Tristan1900
Copy link
Member

LGTM!

@adrianmo adrianmo merged commit abc1174 into master Apr 29, 2019
@adrianmo adrianmo deleted the issue-163-helm-charts branch April 29, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Task not directly related to a feature status/ready The issue is ready to be worked on; or the PR is ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Helm chart for PravegaCluster
2 participants