Release adjustments #176
Merged
Release adjustments #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wenqi <Wenqi.Mou@emc.com>
Signed-off-by: wenqimou <452787782@qq.com>
|
@adrianmo Could you please take a look at the change in Travis? Thank you very much! |
adrianmo
suggested changes
May 7, 2019
Makefile
Outdated
| @@ -57,7 +57,9 @@ login: | |||
|
|
|||
| push: build login | |||
| docker push $(REPO):$(VERSION) | |||
| docker push $(REPO):latest | |||
| if [[ ${TRAVIS_TAG} =~ ^[0-9]+(\.[0-9]+)+(\.[0-9]+)$ ]]; then | |||
There was a problem hiding this comment.
You don't need to create capture groups. Check out the regex pattern we are already using in the code: https://github.com/pravega/pravega-operator/blob/master/pkg/util/pravegacluster.go#L29
adrianmo
reviewed
May 7, 2019
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Pravega Operator | |||
|
|
|||
| [](https://opensource.org/licenses/Apache-2.0) [](https://godoc.org/github.com/pravega/pravega-operator) [](https://travis-ci.org/pravega/pravega-operator) [](https://goreportcard.com/report/github.com/pravega/pravega-operator) | |||
| [](https://opensource.org/licenses/Apache-2.0) [](https://godoc.org/github.com/pravega/pravega-operator) [](https://travis-ci.org/pravega/pravega-operator) [](https://goreportcard.com/report/github.com/pravega/pravega-operator)[](https://github.com/pravega/pravega-operator/releases) | |||
There was a problem hiding this comment.
is it possible to add a dynamic version badge that is automatically updated when releases are published?
added 4 commits
May 7, 2019 13:38
Signed-off-by: wenqimou <452787782@qq.com>
Signed-off-by: wenqimou <452787782@qq.com>
Signed-off-by: wenqimou <452787782@qq.com>
adrianmo
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
latestDocker tag when release candidates are published.Signed-off-by: wenqi Wenqi.Mou@emc.com