Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 435: E2E test failing intermittently #436

Closed
wants to merge 4 commits into from
Closed

Conversation

Prabhaker24
Copy link
Contributor

Signed-off-by: prabhaker24 prabhaker.saxena@dell.com

Change log description

E2E test failing intermittently

Purpose of the change

#435

What the code does

fixes intermittent e2e failure

How to verify it

Travis build should pass

prabhaker24 added 2 commits August 3, 2020 21:03
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #436 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   76.11%   76.13%   +0.02%     
==========================================
  Files          14       14              
  Lines        3320     3323       +3     
==========================================
+ Hits         2527     2530       +3     
  Misses        705      705              
  Partials       88       88              
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravega.go 97.53% <ø> (ø)
pkg/controller/pravega/pravega_controller.go 100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (ø)
pkg/util/pravegacluster.go 97.45% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab8f6e...5f510bc. Read the comment docs.

Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
@Prabhaker24 Prabhaker24 marked this pull request as ready for review August 3, 2020 17:27
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are restarting tier2 at the beginning of tests, can we remove it from the end of the tests.

@Prabhaker24
Copy link
Contributor Author

Closing this pr as fix for moving e2e on cncf cluster is merged in this pr #429 will raise another one for fixing e2e on cncf cluster.

@Prabhaker24 Prabhaker24 closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants