Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation and charts #453

Merged
merged 14 commits into from
Sep 23, 2020
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ $ kubectl create -f ./example/pvc-tier2.yaml

#### Install a Pravega cluster

To understand how to deploy a pravega cluster using helm, refer to [this](charts/zookeeper#installing-the-chart).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this previously zookeeper and now changed to pravega?

To understand how to deploy a pravega cluster using helm, refer to [this](charts/pravega#installing-the-chart).

Once the pravega cluster with release name `bar` has been created, use the following command to verify that the cluster instances and its components are being created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the default name of pravegacluster release name to "pravega" as that's what is given as default pravega name in configmap for bookkeeper by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By giving a different release name, we are able to show that release name and cluster name might not always be the same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that but in the bookkeeper configmap the name for pravega cluster is pravega so for a user deploying for the first time this will create an issue if he deploys pravega with any other release name other than pravega.


Expand Down
11 changes: 7 additions & 4 deletions doc/operator-upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ To install cert-manager check [this](https://cert-manager.io/docs/installation/k

4. Install an Issuer and a Certificate (either self-signed or CA signed) in the same namespace as the Pravega Operator (refer to [this](https://github.com/pravega/pravega-operator/blob/master/deploy/certificate.yaml) manifest to create a self-signed certificate in the default namespace).

5. Execute the script `pre-upgrade.sh` inside the [scripts](https://github.com/pravega/pravega-operator/blob/master/scripts) folder. This script patches the `pravega-webhook-svc` with the required annotations and labels.
5. Execute the script `pre-upgrade.sh` inside the [scripts](https://github.com/pravega/pravega-operator/blob/master/scripts) folder. This script patches the `pravega-webhook-svc` with the required annotations and labels. The format of the command is
```
./pre-upgrade.sh <pravega operator release name> <pravega operator namespace>
```


### Triggering the upgrade
Expand All @@ -117,11 +120,11 @@ where:
- `[tls.crt]` is contained in the above secret and can be obtained using the command `kubectl get secret [secret-name] -o yaml | grep tls.crt`


Once the upgrade completes and the following command starts returning a response instead of throwing an error message (this might take around 7 to 10 minutes after the operator upgrade has been done)
Wait for the upgrade to complete (which can be determined once the following command starts returning a response instead of throwing an error message). This might take around 7 to 10 minutes after the operator upgrade has been done.
```
kubectl describe PravegaCluster <pravega cluster name>
```
Execute the script `post-upgrade.sh` inside the [scripts](https://github.com/pravega/pravega-operator/blob/master/scripts) folder. The format of the command is
Next, execute the script `post-upgrade.sh` inside the [scripts](https://github.com/pravega/pravega-operator/blob/master/scripts) folder. The format of the command is
```
./post-upgrade.sh <pravega cluster name> <pravega release name> <bookkeeper release name> <version> <namespace> <zookeeper svc name> <bookkeeper replica count>
```
Expand All @@ -132,7 +135,7 @@ This script patches the `PravegaCluster` and `BookkeeperCluster` resources with
4. Version of the PravegaCluster or BookkeeperCluster resources (check the output of `kubectl get PravegaCluster` to obtain the version number).
5. Namespace in which PravegaCluster and BookkeeperCluster resources are deployed (this is an optional parameter and its default value is `default`).
6. Name of the zookeeper client service (this is an optional parameter and its default value is `zookeeper-client`).
7. Number of replicas in the BookkeeperCluster (this is an optional parameter and its default value is 3).
7. Number of replicas in the BookkeeperCluster (this is an optional parameter and its default value is `3`).

#### Upgrade manually

Expand Down