-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 97: Update operator SDK dependency to 0.2.0 (full refactor) #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to know whether we can do it in two steps:
- Update the operator SDK without any changes to existing files in the repository or creating new files.
- Change existing files and create new ones as needed.
Otherwise it is virtually impossible to review this PR.
@fpj no, we can't do that. Updating the SDK dependency forces us to refactor our operator code. I know it's very hard to review this PR... I would suggest to ignore changes in the |
d14e675
to
899d7e3
Compare
@fpj I have changed the target branch of this PR to get rid of all the changes coming from 6000+ files under the Once this PR is merged, I'll submit a new PR to merge |
PR has been rebased, needs another review from scratch.
Ignore YAML files in the project root directory Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update vendor directory Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Refactor operator to be in sync with the operator-sdk framework v0.1.1 Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Fix ability to run operator locally Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Fix rebase issues Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
899d7e3
to
796d682
Compare
* operator-sdk-0.1.1: Update vendor dependencies
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Ready for review. |
This PR is already outdated as a new release of the Operator SDK has come out: https://github.com/operator-framework/operator-sdk/releases/tag/v0.2.0 I'll investigate what the changes are and update our operator again. |
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
* operator-sdk-0.1.1: Update Gopkg files Update vendor dir
* operator-sdk-0.1.1: Update vendor
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Install minikube on Travis Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Use local bootstrap instead of systemd Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Use Kubernetes 1.9 Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Use MiniKube v0.28.2 Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update Minikube config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update Minikube config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update Minikube config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update Minikube config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update Minikube config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update Minikube config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com> Update travis config Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
d11a9a1
to
7897372
Compare
PR is ready for reviewing. /cc @fpj @shrids @Tristan1900 |
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
I test this branch manually and through testing framework. It works well. |
vendor/github.com/operator-framework/operator-sdk/commands/operator-sdk/cmd/add/controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
* operator-sdk-0.1.1: Update project dependencies
Signed-off-by: Adrian Moreno <adrian@morenomartinez.com>
@fpj thanks for the review. I've addressed all your comments and fixed the conflicting |
Change log description
The Operator SDK project is moving fast and they have recently moved to a new
0.2.0
minor version that brings new features and completely refactors the operator framework. If we don't want to be left behind, we need to keep updating our operator SDK dependency, specially now that the project is still in an early stage and evolves fast.Changes:
0.0.5
to0.2.0
. Applied the official migration guide step by step to migrate the existing operator project to be compliant with the latest SDK.test-e2e
make command that runs the end-to-end testsvendor
directory. Ignore those when reviewing the changes.Purpose of the change
How to test the change
Checkout the repository (
master
branch is fine, no need to checkout this branch).Edit the operator image used in the
deploy/operator.yaml
file to use theadrianmo/pravega-operator:issue-97-3
image, which contains the changes in this PR.Follow the regular README file to install the operator and deploy the operator.
When you deploy the operator, check the logs to make sure you are using an operator based on the
0.2.0
SDK.When you deploy a Pravega cluster, make sure it creates all resources as usual.