Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug information to hopefully fix future problems #1458

Closed
wants to merge 3 commits into from
Closed

Add debug information to hopefully fix future problems #1458

wants to merge 3 commits into from

Conversation

PythonCoderAS
Copy link
Contributor

As the title says, this should give some insight into how the directory looks on the test system. The script can also be run locally to make comparisons to find problems.

@PythonCoderAS PythonCoderAS added the Developer Environment Related to the development process label Apr 29, 2020
@bboe
Copy link
Member

bboe commented Apr 29, 2020

Thanks for the efforts here. I don't think adding such a script is necessary, because such issues are typically a one-off. I'd be more curious to know what changed resulting in the build-directory showing up.

@PythonCoderAS
Copy link
Contributor Author

@bboe Per #1456 , the build directory showed up due to pip's new way of handling pip install .[...].

@bboe
Copy link
Member

bboe commented Apr 29, 2020

Thanks for the response. I ended up reading that issue after reading through this PR. I think your solution to clean up makes sense. Adding some debugging tooling here, I think is handy for you to keep around if you need it, but I don't think we need to add such tooling to the project.

@PythonCoderAS
Copy link
Contributor Author

The point of this PR is for future proofing. It would be inconvenient to introduce this code when an issue occurs, and remove it after. The debug information is hidden anyways, so it's not obstructing actual log values.

@bboe
Copy link
Member

bboe commented Apr 29, 2020

The point of this PR is for future proofing. It would be inconvenient to introduce this code when an issue occurs, and remove it after. The debug information is hidden anyways, so it's not obstructing actual log values.

I understand the value you feel this tool adds. I also know it was something you could probably recreate in under an hour if necessary. Little tools like this can clutter the project, and they offer little value most of the time.

@PythonCoderAS
Copy link
Contributor Author

The point of this PR is for future proofing. It would be inconvenient to introduce this code when an issue occurs, and remove it after. The debug information is hidden anyways, so it's not obstructing actual log values.

I understand the value you feel this tool adds. I also know it was something you could probably recreate in under an hour if necessary. Little tools like this can clutter the project, and they offer little value most of the time.

I'll close this PR but add it to my .git/ignore so I can still use it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Environment Related to the development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants