-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre commit hooks #1774
Update pre commit hooks #1774
Changes from all commits
4cf4464
d9aaead
e40a958
6eb661b
9fddbe1
16900b3
55de585
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,7 @@ | ||
[flake8] | ||
exclude = .eggs,build,docs,.venv* | ||
ignore = E203 E501 W503 W504 | ||
per-file-ignores = | ||
praw/models/__init__.py:F401 | ||
praw/models/listing/mixins/__init__.py:F401 | ||
praw/models/reddit/mixins/__init__.py:F401 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
jobs: | ||
auto-update: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-python@v2 | ||
- uses: browniebroke/pre-commit-autoupdate-action@main | ||
- uses: peter-evans/create-pull-request@v3 | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
branch: update/pre-commit-hooks | ||
title: Update pre-commit hooks | ||
commit-message: "Update pre-commit hooks" | ||
body: Update versions of pre-commit hooks to the latest version. | ||
name: 'Update pre-commit hooks' | ||
on: | ||
schedule: | ||
- cron: '0 15 * * 1' | ||
workflow_dispatch: |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,4 +41,3 @@ on: | |
branches: | ||
- master | ||
- release_test | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,62 @@ | ||
fail_fast: true | ||
repos: | ||
- hooks: | ||
- id: black | ||
language_version: python3 | ||
repo: https://github.com/psf/black | ||
rev: 20.8b1 | ||
|
||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
hooks: | ||
- id: end-of-file-fixer | ||
exclude: .*\.txt | ||
rev: v4.0.1 | ||
|
||
- repo: local | ||
hooks: | ||
- id: static_word_checks | ||
args: | ||
- '--replace' | ||
entry: python -m tools.static_word_checks | ||
language: system | ||
name: Static Word Checks | ||
pass_filenames: false | ||
types: [ python ] | ||
|
||
- id: check_documentation | ||
entry: python -m tools.check_documentation | ||
language: system | ||
name: Check Documentation | ||
pass_filenames: false | ||
types: [ python ] | ||
|
||
- repo: https://github.com/psf/black | ||
hooks: | ||
- id: black | ||
language_version: python3 | ||
rev: 21.7b0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it possible to make this work without setting the value There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's set by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Requiring hooks to have pinned versions is a core design decision of pre-commit, since it ensures that all developers and CIs get the same consistent version of hooks for a given project repository commit, and thus hooks don't arbitrarily fail or make different changes based on whatever version happens to be installed on the current platform. There's also a GH action that, like dependabot, automatically submits PRs at a reasonable frequency to upgrade out of date hooks. |
||
|
||
- repo: https://github.com/LilSpazJoekp/docstrfmt | ||
hooks: | ||
- id: docstrfmt | ||
rev: v1.4.0 | ||
|
||
- repo: https://github.com/pycqa/flake8 | ||
hooks: | ||
- id: flake8 | ||
rev: 3.9.2 | ||
|
||
- repo: https://github.com/ikamensh/flynt/ | ||
hooks: | ||
- id: flynt | ||
args: | ||
- '-ll' | ||
- '1000' | ||
- '-tc' | ||
language_version: python3.8 | ||
rev: '0.66' | ||
|
||
- repo: https://github.com/pycqa/isort | ||
hooks: | ||
- id: isort | ||
rev: 5.9.3 | ||
|
||
- repo: https://github.com/pycqa/pydocstyle | ||
hooks: | ||
- id: pydocstyle | ||
files: praw/.* | ||
rev: 6.1.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
[tool.black] | ||
exclude = '/(\.eggs|\.git|\.hg|\.mypy_cache|\.nox|\.tox|\.venv.*|_build|buck-out|build|dist)/' | ||
extend_exclude = '/(\.venv.*)/' | ||
line-length = 88 | ||
|
||
[tool.docstrfmt] | ||
extend_exclude = ['./docs/examples/'] | ||
|
||
[tool.isort] | ||
profile = "black" | ||
skip_glob = '.venv*' | ||
profile = 'black' | ||
skip_glob = '.venv*' |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,2 @@ | ||
[aliases] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is the purpose of the setup.cfg here if you already have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is settings for setuptools. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, this setting and |
||
test = pytest | ||
|
||
[flake8] | ||
ignore = E203 W503 | ||
per-file-ignores = | ||
praw/models/__init__.py:F401 | ||
praw/models/listing/mixins/__init__.py:F401 | ||
praw/models/reddit/mixins/__init__.py:F401 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -449,4 +449,4 @@ | |
} | ||
], | ||
"recorded_with": "betamax/0.8.1" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would even go as far as to do
praw/*/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine as is.