Use a cell's specified font to determine text cell content width. #42 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@packetmonkey: Would you be okay if I merge this in? This seems like a pretty simple bugfix to me. From Prawn's contributor notes:
|
|
👍 |
jessedoyle
added a commit
that referenced
this pull request
Nov 15, 2015
Use a cell's specified font to determine text cell content width. #42
|
Great, thanks! |
This was referenced Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
styled_width_ofmethod incell/text.rbseemed to use the document's current font for all text width calculations.This PR changes that behaviour to use the cell's particular font if specified, then use the document's current font.
The previous behaviour was causing a bug with Prawn::Icon, and I'm sure others have encountered this bug in the past (#42).