Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow #1278

Closed
wants to merge 2 commits into from
Closed

Conversation

mishina2228
Copy link

@mishina2228 mishina2228 commented Jan 1, 2023

- Bump actions/checkout from v1 to v3
- Enable `bundler-cache`
- Add Ruby 3.2 to the CI matrix
@gettalong
Copy link
Member

If I remember correctly, there was a reason why the bundler cache was not used. Should be a comment on a pull request similar to this one.

@pointlessone
Copy link
Member

By default these actions install gems inside the project root which messes up RuboCop check because it check all ruby files in the project root. At least that's how I remember it. Maybe things have changed since then or I might've dome something wrong. In any case CI is clearly misconfigured…

@mishina2228
Copy link
Author

By default these actions install gems inside the project root which messes up RuboCop check because it check all ruby files in the project root.

Yeah, that's why I had to change .rubocop.yml to make RuboCop ignore the ruby files in gem dependencies.
I've edited the description to mention it.

@technicalpickles
Copy link

RuboCop check because it check all ruby files in the project root

Looks like this might be an upstream issue, found rubocop/rubocop#9325 which I think describes it. Another fix for this seems to be this in .rubocop.yml:

inherit_mode:
  merge:
    - Exclude

@mishina2228
Copy link
Author

I see that the changes in this PR are already in the master branch.
I also understand about the policy of not using bundler-cache from this comment, so I'm closing this PR.

@mishina2228 mishina2228 closed this Mar 9, 2023
@pointlessone
Copy link
Member

@mishina2228 Thank you for your contribution and understanding.

@mishina2228 mishina2228 deleted the update-ci-workflow branch March 9, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants