-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action fails if saving cache fails #53
Comments
dupe of #41 -- I'm not sure there's anything that can be done but feel free to send a PR if you think there is |
6 tasks
dhimmel
added a commit
to dhimmel/obonet
that referenced
this issue
Apr 4, 2021
jobs fail due to pre-commit/action#53
dhimmel
added a commit
to dhimmel/obonet
that referenced
this issue
Apr 4, 2021
jobs fail due to pre-commit/action#53
asottile
added a commit
that referenced
this issue
Apr 5, 2021
Fix Action fails if saving cache fails #53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all thanks for this action 😄
Today I had my pre-commit job failing, with the following error, which isn't fixable by rerunning the job:
My best guess is, that this caused by a corrupted cache, where a cache entry with the key exists, but
cache.restoreCache
is unable to restore it properly (maybeon: push
andon: pull_request
wanted to save the cache at the same time? 😵 ).So this might be a very rare and quite impossible to reproduce case.
Anyway, since the cache is nice and all, but not a key feature, IMHO it would be reasonable to catch errors caused by
cache.saveCache
and give users a warning (core.warning
), instead of letting it bubble up tocore.setFailed
.action/index.js
Line 87 in 763fbaf
Also, there have been some changes to
@actions/cache
since version 0.2.1 which you use, so runningnpm upgrade
might improve this action as well.The text was updated successfully, but these errors were encountered: