-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forbid-new-submodules is broken #609
Comments
@m-khvoinitsky in order to add a submodule |
That's correct if you're adding submodules intentionally. But if user tries to commit some another git repository inside current one by accident, git complains but obediently adds a "commit" (type 160000) entry in the tree. I was hoping that this hook would prevent such situations too.
May be it is. If so, a separate hook which rejects type 160000 entries without corresponding records in .gitmodules suits my needs better. However, implementing proposed chages would make this hook useful in both usecases (which makes sense because rejecting "incomplete" submodule is still rejecting a submodule). |
feel free to take a stab if you think it's worth it, I'm just not sure you're solving something that's actually a problem |
…s committed (without any other file); support --from-ref and --to-ref; fixes pre-commit#609
…s committed (without any other file); support --from-ref and --to-ref; fixes pre-commit#609
…s committed (without any other file); support --from-ref and --to-ref; fixes pre-commit#609
…s committed (without any other file); support --from-ref and --to-ref; fixes pre-commit#609
…s committed (without any other file); support --from-ref and --to-ref; fixes pre-commit#609
…s committed (without any other file); support --from-ref and --to-ref; fixes pre-commit#609
The hook does not have an explicit
types
section.Default
types: [file]
does not match submodules (which are directories). It works only if you commit some regular file together with committing new submodule.Specifying
types: [directory]
helps but not much: it works as a pre-commit but doesn't as pre-push or any other way when you specify--from-ref
and--to-ref
.I'd suggest stopping ignoring provided by pre-commit list of files and check
git status
for provided files instead of diff.The text was updated successfully, but these errors were encountered: