Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent name and description values #634

Closed
wants to merge 2 commits into from

Conversation

revolter
Copy link
Contributor

No description provided.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would actually prefer them all lower-cased as #413

@revolter
Copy link
Contributor Author

Why? 😃 They're harder to be recognized if they're lowercase.

Also, it's like using Javascript instead of JavaScript. If the official website uses JSON, then it's JSON.

@asottile
Copy link
Member

why do you want them upper case? I don't need a reason I want them lower cased

@revolter
Copy link
Contributor Author

why do you want them upper case?

For the same reason that I want to be called Iulian, and not iulian 😂 Because that's my name.

Also, in this specific case: https://en.wikipedia.org/wiki/Acronym#All-caps_style.

dennisroche added a commit to dennisroche/pre-commit-hooks that referenced this pull request Oct 18, 2021
Sorry for raising such a trival PR. 

Perhaps better solved by pre-commit#634
@asottile asottile closed this Oct 19, 2021
@revolter
Copy link
Contributor Author

Would you accept this if I change JSON, TOML, etc. to lowercase? 😞

@asottile
Copy link
Member

#671 already did

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants