chore(templates): add SSG template #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
reviewed
Jul 27, 2023
rschristian
reviewed
Jul 27, 2023
JoviDeCroock
force-pushed
the
ssr-template
branch
3 times, most recently
from
36bcd6c to
08c05e8
Compare
JoviDeCroock
force-pushed
the
ssr-template
branch
from
08c05e8 to
8251d62
Compare
JoviDeCroock
commented
Jul 27, 2023
| prompts.confirm({ | ||
| message: 'Use router?', | ||
| initialValue: false, | ||
| }), | ||
| }) : Promise.resolve(false), |
There was a problem hiding this comment.
@rschristian do you know if there is a better way to do this? It looks like it goofs up our types
There was a problem hiding this comment.
I do not, no. Clack does have some wonky types in places but it's been something I'm fine with // @ts-ignore'ing or whatever if the red squiggle is annoying for people.
We can ungroup the prompts, do something like this to get better control flow, but it's perhaps a bit repetitive.
JoviDeCroock
force-pushed
the
ssr-template
branch
from
8251d62 to
19ca1ae
Compare
rschristian
approved these changes
Jul 27, 2023
rschristian
pushed a commit
that referenced
this pull request
Aug 4, 2023
* ssg template * todos * fixes * use appType * ignore error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an SSG-template using
vite-plugin-ssr, I am however curious how we'd incorporate this in our current setup would we do-> base/ssg?
--> base ? use-router? : none
--> useTS ?