Typescript support #747
Merged
Typescript support #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
force-pushed
the
typescript
branch
from
3d58946 to
e3e2220
Compare
developit
reviewed
Mar 1, 2019
| loader: 'awesome-typescript-loader', | ||
| options: { | ||
| silent: true, | ||
| useBabel: true, |
There was a problem hiding this comment.
I think this will break BabelEsmPlugin, which looks for babel-loader.
Would it be possible to run awesome-ts-loader as {enforce:'pre'} and then pass /\.[tj]sx?/ files to babel-loader after?
There was a problem hiding this comment.
hmm good question
ForsakenHarmony
force-pushed
the
typescript
branch
from
335d940 to
8cea3ea
Compare
sync
reviewed
Mar 7, 2019
packages/cli/package.json
Outdated
| @@ -108,6 +110,9 @@ | |||
| "stack-trace": "0.0.10", | |||
| "style-loader": "^0.23.1", | |||
| "sw-precache-webpack-plugin": "^0.11.2", | |||
| "terser-webpack-plugin": "^1.1.0", | |||
| "typescript": "^3.3.3333", | |||
| "unfetch": "^4.0.1", | |||
There was a problem hiding this comment.
Just curious, what are we doing with unfetch ?
There was a problem hiding this comment.
good question, no idea where that came from, probably something old that slipped in
|
Would be great to get “plug and play” ts support |
ForsakenHarmony
force-pushed
the
typescript
branch
3 times, most recently
from
41dabe3 to
ba8f4c0
Compare
ForsakenHarmony
force-pushed
the
typescript
branch
2 times, most recently
from
7c29ba2 to
2d25317
Compare
developit
approved these changes
Mar 15, 2019
ForsakenHarmony
force-pushed
the
typescript
branch
from
2d25317 to
fd994f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.