Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
🐛 fix
Did you add tests for your changes?
N/A
Summary
In
webpack-dev-server
v3.4.0, theclientLogLevel
value ofnone
was removed and replaced withsilent
. As v3.4.0 falls inpreact-cli
's range of^3.3.1
, andwebpack-dev-server
strictly validates its options before starting, this should be causingpreact watch
to fail if the project was created after said dev server version was published.See webpack/webpack-dev-server#1825
Does this PR introduce a breaking change?
No (other than bumping
webpack-dev-server
, which could be considered a breaking change, and probably should have on their part).Other information