Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch all scripts in pkg.json to use yarn #491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rschristian
Copy link
Member

Super minor, but was fiddling around with the ecosystem CI and came across this.

As some scripts use npm run, despite this being a yarn repo, it breaks the passing of flags to commands, e.g., yarn test:e2e:10 --retries 5 wouldn't work as npm strips out the --retries portion, only passing on the 5. The CI here also works around this, duplicating the v10 e2e script just to add the flag it needs.

Switching these over to yarn makes more sense and allows for passing of flags nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant