Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown upon clicking any non-link #46

Closed
tomjw64 opened this issue Oct 20, 2024 · 2 comments · Fixed by #47
Closed

Error thrown upon clicking any non-link #46

tomjw64 opened this issue Oct 20, 2024 · 2 comments · Fixed by #47

Comments

@tomjw64
Copy link
Contributor

tomjw64 commented Oct 20, 2024

Upon switching to preact-iso from preact-router my app now throws an error anytime a click occurs on any non-anchor element:
Screenshot from 2024-10-19 21-04-21

I believe it's a result of not checking for null here in this recent PR
@rschristian
Copy link
Member

Crap, good spot.

@tomjw64 tomjw64 mentioned this issue Oct 20, 2024
Merged
@rschristian
Copy link
Member

Fix released in v2.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add null check for link before usage tomjw64/preact-iso
2 participants
@tomjw64 @rschristian