Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null check for link before usage #47

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Add null check for link before usage #47

merged 2 commits into from
Oct 20, 2024

Conversation

tomjw64
Copy link
Contributor

@tomjw64 tomjw64 commented Oct 20, 2024

Resolves #46

rschristian
rschristian reviewed Oct 20, 2024
View reviewed changes
src/router.js Outdated Show resolved Hide resolved
@tomjw64 tomjw64 requested a review from rschristian October 20, 2024 02:30
rschristian
rschristian approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I had spotted something last night which made me suspect an issue, but hadn't had the chance to check yet.

Will push a patch in the next couple of minutes.

@rschristian rschristian merged commit 8490100 into preactjs:main Oct 20, 2024
1 check passed
@tomjw64 tomjw64 deleted the link-null-check branch October 20, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error thrown upon clicking any non-link
2 participants
@tomjw64 @rschristian