Skip to content

Fix support for default context value #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Fix support for default context value #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
// the context value as `this.context` just for this component.
let cxType = nodeName.contextType;
let provider = cxType && context[cxType.__c];
let cctx = cxType != null ? (provider ? provider.props.value : cxType._defaultValue) : context;
let cctx = cxType != null ? (provider ? provider.props.value : cxType.__) : context;

// stateless functional components
rendered = nodeName.call(vnode.__c, props, cctx);
Expand All @@ -95,7 +95,7 @@ function renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {
// class-based components
let cxType = nodeName.contextType;
let provider = cxType && context[cxType.__c];
let cctx = cxType != null ? (provider ? provider.props.value : cxType._defaultValue) : context;
let cctx = cxType != null ? (provider ? provider.props.value : cxType.__) : context;

// c = new nodeName(props, context);
c = vnode.__c = new nodeName(props, cctx);
Expand Down
17 changes: 17 additions & 0 deletions test/context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,21 @@ describe('context', () => {
<section>value is: </section>
`);
});

it('should support default context value with absent provider', () => {
const { Consumer } = createContext('correct');
let rendered = renderJsx(
<Consumer>
{(value) => (
<section>
value is: {value}
</section>
)}
</Consumer>
);

expect(rendered).to.equal(dedent`
<section>value is: correct</section>
`);
});
});