Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmount option hook call performance #270

Merged
merged 2 commits into from
Feb 25, 2023
Merged

Conversation

developit
Copy link
Member

This is a tiny performance improvement for unmount option hook.

Screenshot 2022-11-15 at 7 21 34 PM

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2022

🦋 Changeset detected

Latest commit: 7d42d12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Let's add a changeset too 👍

@JoviDeCroock JoviDeCroock merged commit 5c6877d into master Feb 25, 2023
@JoviDeCroock JoviDeCroock deleted the unmount-hook-perf-tweak branch February 25, 2023 08:27
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants