Remove trailing space for void elements #282
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 592a4ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
What's the benefit here? Seems like it could be a really difficult change for people to pick up if lots of tests use this. |
|
The being more in-line with the output React produces and it being a tad smaller resounded with me, however open to rebuttal there :D Note that the next version will be a major either way |
developit
approved these changes
Feb 26, 2023
|
Not sure how this works with Changesets, but could we somehow put this into whatever the next major is, rather than creating a major for this change on its own? |
|
@developit added it |
andrewiggins
approved these changes
Mar 24, 2023
Merged
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as major in case people rely on this for tests
Fixes #279