Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TS definition for Router onChange prop #215

Merged
merged 4 commits into from
Aug 23, 2017
Merged

Added TS definition for Router onChange prop #215

merged 4 commits into from
Aug 23, 2017

Conversation

cmaster11
Copy link
Contributor

The onChange prop was not mapped in the definitions file. This is a possible change.

@cmaster11
Added TS definition for Router onChange prop
6bfae18 
The onChange prop was not mapped in the definitions file. This is a possible change.
Alexendoo
Alexendoo requested changes Jul 18, 2017
View reviewed changes
Copy link
Collaborator

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe current should be a VNode and and active an Array of VNodes. previous may be undefined also (on the first callback)

@cmaster11
Copy link
Contributor Author

Yep! Missed that!

@cmaster11
Fixed onChange definition
a359fd9 
Actual typo, `onChange` was written as a function to be invoked. Now it's the correct attribute type.
@jmfirth jmfirth mentioned this pull request Jul 20, 2017
Closed
@kwoon kwoon mentioned this pull request Jul 21, 2017
Closed
developit
developit approved these changes Aug 23, 2017
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@reznord reznord mentioned this pull request Aug 23, 2017
Closed
@developit developit merged commit c2c4693 into preactjs:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaster11 @developit @Alexendoo