Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash History v5 Compatibility #410

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Hash History v5 Compatibility #410

merged 5 commits into from
Nov 26, 2021

Conversation

developit
Copy link
Member

@developit developit commented Nov 23, 2021

This adds a check that should make preact-router compatible with both v4 and v5 of the history module (the API changed).

This fixes #378.

@developit
Copy link
Member Author

I'd like to find time to add a test for this before merging.

@github-actions
Copy link

github-actions bot commented Nov 24, 2021

Size Change: +152 B (+2%)

Total Size: 8.15 kB

Filename Size Change
dist/preact-router.es.js 2.04 kB +37 B (+2%)
dist/preact-router.js 2 kB +39 B (+2%)
dist/preact-router.modern.js 2.04 kB +36 B (+2%)
dist/preact-router.umd.js 2.07 kB +40 B (+2%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page does not refresh when press browser back button, if hash history is being used
2 participants