blog: Prerendering with @preact/preset-vite
#1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Aug 7, 2024
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
rschristian
commented
Aug 7, 2024
| } | ||
| ``` | ||
|
|
||
| ### Using `globalThis` to pass data around |
There was a problem hiding this comment.
I like the later example of having a global cache to write to, but I'm a bit unsure about passing other data. I'm worried that this could lead to race conditions given that we also support async rendering in RTS now.
There was a problem hiding this comment.
In the first example? I don't see how there could be any race conditions, short of someone forgetting to await the async RTS.
And, fundamentally, passing data out of the render tree (like with the document.title example) is quite difficult without globalThis -- you'd be left with trying to parse it out of the resulting HTML in all likelihood.
Edit: Misread slightly
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
marvinhagemeister
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much of a writer so let me know if there are any opinions on topics, direction, etc.!