Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Context API is now supported in base package. #454

Closed
wants to merge 1 commit into from
Closed

New Context API is now supported in base package. #454

wants to merge 1 commit into from

Conversation

jackbravo
Copy link

According to preactjs/preact#963 (comment), new Context API is now part of Preact.

According to preactjs/preact#963 (comment), new Context API is now part of Preact.
@size-plugin
Copy link
Contributor

size-plugin bot commented Oct 11, 2019

Size report for the changes in this PR:

size-plugin-ssr Overall size: 208 kB

    editor.chunk.*****.js ⏤  65.9 kB
     emoji.chunk.*****.js ⏤  8.83 kB
    runner.chunk.*****.js ⏤  5.86 kB
            ssr-bundle.js ⏤  28.6 kB
   editor.chunk.7a736.css ⏤  3.17 kB
 markdown.c3d26.worker.js ⏤  9.56 kB
    prism.e82c3.worker.js ⏤  7.24 kB
     repl.51501.worker.js ⏤  68.5 kB
     ssr-bundle.ac3c8.css ⏤  10.9 kB

commit: 93bf2ba

@JoviDeCroock
Copy link
Member

You made this change in the v8 docs the x docs already document this change.

@size-plugin
Copy link
Contributor

size-plugin bot commented Oct 11, 2019

Size report for the changes in this PR:

size-plugin-browser Overall size: 395 kB

                 sw-esm.js ⏤  682 B
                     sw.js ⏤  678 B
  emoji.chunk.91398.esm.js ⏤  8.85 kB
    polyfills.6a525.esm.js ⏤  2.13 kB
      emoji.chunk.1ed91.js ⏤  8.85 kB
        polyfills.3233a.js ⏤  2.12 kB
    editor.chunk.7a736.css ⏤  2.15 kB
 editor.chunk.fa6b3.esm.js ⏤  66.3 kB
         5.chunk.bc319.css ⏤  1.47 kB
      5.chunk.95a73.esm.js ⏤  3.39 kB
     editor.chunk.e0251.js ⏤  66.4 kB
          5.chunk.b2018.js ⏤  3.45 kB
          bundle.c6f3d.css ⏤  9.11 kB
     prism.d329b.worker.js ⏤  7.32 kB
  markdown.6af7e.worker.js ⏤  9.66 kB
      repl.bfeb7.worker.js ⏤  66.7 kB
       bundle.6ee5f.esm.js ⏤  22.9 kB
 runner.chunk.097ea.esm.js ⏤  5.79 kB
  markdown.d9ce1.worker.js ⏤  9.66 kB
      repl.6e676.worker.js ⏤  68.1 kB
           bundle.31633.js ⏤  23.2 kB
     runner.chunk.50868.js ⏤  5.83 kB

commit: 93bf2ba

@jackbravo
Copy link
Author

Oups! You are right! So sorry.

@jackbravo jackbravo closed this Oct 11, 2019
@jackbravo
Copy link
Author

I was investigating on preact (now that AMP is going to be based on it :-p) and saw preact-context mentioned in a bunch of places, which was confusing. I don't remember how I ended on v8 version of the docs instead of 10.

@jackbravo jackbravo deleted the patch-1 branch October 11, 2019 14:51
@JoviDeCroock
Copy link
Member

No problem, happens! If you have any questions feel free to post them on slack dev channel too

@jackbravo
Copy link
Author

I made this other PR for the same reason: preactjs/preact#2001

And added this issue on the preact-context project: valotas/preact-context#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants