Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show edit page link / no translation found on tutorial pages #986

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/controllers/page/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export default function Page({ route, prev, next }, ctx) {
// "current" is the currently *displayed* page ID.

const showTitle = current != 'index' && meta.show_title !== false;
const canEdit = showTitle && current != '404' && current !== '/blog';
rschristian marked this conversation as resolved.
Show resolved Hide resolved
const canEdit = showTitle && current != '404';
const hasSidebar = meta.toc !== false && isDocPage(url);

return (
Expand Down
4 changes: 3 additions & 1 deletion src/components/controllers/tutorial/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { useStore, storeCtx } from '../../store-adapter';
import { InjectPrerenderData } from '../../../lib/prerender-data';
import { getContent } from '../../../lib/content';
import { Splitter } from '../../splitter';
import EditThisPage from '../../edit-button';

const IS_PRERENDERING = typeof window === 'undefined';

Expand Down Expand Up @@ -284,7 +285,8 @@ function TutorialView({
}
>
<div class={style.tutorialWindow} ref={content}>
<h1 class={style.title}>{title}</h1>
<EditThisPage show={title != 'Error'} isFallback={page.isFallback} />
<h1>{title}</h1>
rschristian marked this conversation as resolved.
Show resolved Hide resolved

<ContentRegion
name={page.current}
Expand Down
4 changes: 2 additions & 2 deletions src/components/controllers/tutorial/style.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
}

& > h1 {
margin: 0;
margin: 2.5rem 0 0;
padding: 0.25em 0;
font-size: 2.5rem;
font-weight: 200;
Expand Down Expand Up @@ -211,7 +211,7 @@

&:not(.showCode) {
.tutorialWindow {
& > * {
& > :not(:first-child) {
// Fixes content region whilst keeping
// title & button container centered
&:nth-child(2) {
Expand Down