Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify context support #1167

Closed
tejohnso opened this issue Jul 11, 2018 · 2 comments
Closed

Clarify context support #1167

tejohnso opened this issue Jul 11, 2018 · 2 comments
Labels
documentation help wanted

Comments

@tejohnso
Copy link

tejohnso commented Jul 11, 2018 •
edited
Loading

The Differences to React page indicates that context support is included since 3.0 and links to React's Context page which describes the createContext api.

But on the other hand PR 963 is meant to implement the "new" context api.

It seems the Differences to React page is pointing to the new api and not the old api that is actually supported. And there's no other Preact documentation indicating how context is currently supposed to be used.
@developit
Copy link
Member

Correct! I believe it's only been a couple of months since that API was introduced to React, and our documentation needs to be updated. There's a repo for the preact website if you're interested in helping out!

@tejohnso tejohnso mentioned this issue Jul 12, 2018
Merged
@tejohnso
Copy link
Author

PR submitted https://github.com/developit/preact-www/pull/226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@developit @tejohnso