Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context api documentation #226

Merged
merged 1 commit into from
Jul 15, 2018
Merged

Update context api documentation #226

merged 1 commit into from
Jul 15, 2018

Conversation

tejohnso
Copy link
Contributor

@tejohnso tejohnso commented Jul 12, 2018 •
edited
Loading

Resolves #1167, clarifying support for old React Context API rather than the new API.

@tejohnso
Update context api documentation
87df5f1 
Resolves preactjs#1167, clarifying support for old React Context API rather than the new API.
@tejohnso tejohnso mentioned this pull request Jul 12, 2018
Closed
marvinhagemeister
marvinhagemeister approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@reznord
Copy link
Member

reznord commented Jul 15, 2018

@marvinhagemeister IIRC, for the new context API, we can use preact-context right?

@reznord reznord merged commit 933f65b into preactjs:master Jul 15, 2018
@tejohnso tejohnso deleted the patch-1 branch July 15, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@reznord reznord reznord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejohnso @reznord @marvinhagemeister