Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ceviche repo 🎉 #1302

Merged
merged 981 commits into from
Mar 4, 2019
Merged

Merge ceviche repo 🎉 #1302

merged 981 commits into from
Mar 4, 2019

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 2, 2019 •
edited
Loading

This PR merges the code from ceviche back into the public repo. ceviche is our codename for Preact X. An alpha release on npm will follow shortly on March 4th.

Todos:

  • Resolve Merge-Conflicts
  • Preserve git history of both projects
  • Verify changes with git diff ceviche..ceviche/master
  • Remove 8.x code that's been unaffected by the merge
  • Verify TS types, children type-checking seems to be broken.
  • Fix missing Text-Nodes in Children tests.
  • Fix missing code coverage in compat.

Note: The commit view here on GitHub doesn't show all commits. The most recent ones are missing for me in the web ui. They're all there when viewed locally via git.

marvinhagemeister and others added 30 commits January 31, 2019 11:08
@marvinhagemeister
Merge pull request #205 from developit/create-context-type
a37e20c 
Add support for `class.contextType`
@marvinhagemeister
Skip failing createContext tests
19bf0b7
@andrewiggins
Enable fragment DOM logs & improve sibling array children test
50ee2b7
@andrewiggins
Add test for components that conditionally return Fragments
ba2ca59
@andrewiggins
Determine first childDom inside diffChildren (-10 B)
e7d7989
@andrewiggins
WIP: Add _wrapsFragment comparison
09ffff9
@andrewiggins
Simplify _lastDomChild tracking (+0 B)
582b358 
Only track lastDomChild for Fragment-like VNodes (i.e. Fragments and Components that return Fragments)

Remove _wrapsFragment experiment
@andrewiggins
Remove parentVNode tracking from diff (-16 B)
935a300
@andrewiggins
Pass parent vnodes into diffChildren instead of children arrays (-16 B)
8ff7cb9
@andrewiggins
Combine hydrate and render to both call diffChildren (-27 B)
67967d5 
Temporarily disable the devtools tests as I broke them badly :/
@andrewiggins
Remove diff "append" parameter and inline append code in the only pla…
86c96df 
…ce it would be invoked (-13 B)
@ForsakenHarmony
Merge remote-tracking branch 'origin/create-context' into create-cont…
b257110 
…ext-nested

# Conflicts:
#	src/diff/index.js
@ForsakenHarmony
fix eslint
9e34da5
@ForsakenHarmony
Merge pull request #204 from developit/create-context-nested
9c6c1e0 
Add support for nested createContext providers
@ForsakenHarmony
don't put the whole component into context
ddb5612
@ForsakenHarmony
enable tests again
c1c8191
@ForsakenHarmony
Merge remote-tracking branch 'origin/master' into create-context
9e06a55
@marvinhagemeister
Update isRoot check for wrapped Fragment
014f033
@marvinhagemeister
Remove patched virtual wrapper node
b7afff4
@marvinhagemeister
Fix missing events due to root Fragment
867b81b
@marvinhagemeister
Make sure that rootCommitted is a root node
eae1d1d
@marvinhagemeister
Refactor root handling to account for root Fragment
d60c481
@marvinhagemeister
Fix checkJs types in devtool tests
3878582
@marvinhagemeister
Add PubSub to createContext
e83986a
@marvinhagemeister
minimal golf
34c8a89
@marvinhagemeister
Remove unneeded constructor call
e94e9eb
@marvinhagemeister
Golf by assigning prototype -2
8eb4520
@marvinhagemeister
Mangle internal state name -3b
0cad57a
@marvinhagemeister
Golf var creation -3b
d8ea0bd
@andrewiggins
Merge #208: Adapt devtools to root Fragment node
b34e9b2 
From developit/diff-children-devtools
andrewiggins
andrewiggins approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thysultan
Copy link

Minor change 1 is going to prove hot on the wheels of browsers, at least in comparison to the current implementation, and when hooks land; considering inline-functions will become more common in that space. Is there any reason the previous route was ditched – 1 listener mount + a map of callbacks that are updated?

@marvinhagemeister
Copy link
Member Author

marvinhagemeister commented Mar 4, 2019 •
edited
Loading

@thysultan The changelog isn't really up to date. Event listeners in ceviche work the same way as they do in current preact. That section was written before we implemented them there.

To avoid any further confusion I've removed the CHANGELOG.md.

@hassanbazzi hassanbazzi self-requested a review March 4, 2019 07:06
@hassanbazzi
Copy link
Member

So exciting!

@dyaa
Copy link

dyaa commented Mar 4, 2019

Merge time, and let the community celebrate? :shipit: 👯 🎉

@mochiya98
Copy link
Contributor

Why is not included "compat/*" in package.files?

@marvinhagemeister
Copy link
Member Author

marvinhagemeister commented Mar 4, 2019 •
edited
Loading

@mochiya98 Good catch! Just pushed a commit that adds compat to the files section. Thanks again for spotting this 👍

@developit developit merged commit 0c104d9 into master Mar 4, 2019
@developit
Copy link
Member

aaaaand we're a go

@dyaa
Copy link

dyaa commented Mar 4, 2019

@developit dont forget the npm release 😉

This was referenced Mar 4, 2019
Closed
Closed
Closed
Closed
Closed
@ForsakenHarmony ForsakenHarmony deleted the ceviche branch March 4, 2019 17:30
This was referenced Mar 4, 2019
Closed
Closed
Closed
@reznord reznord mentioned this pull request Mar 4, 2019
Closed
@flppv
Copy link

flppv commented Mar 4, 2019

Great job! Waiting for updated docs and release notes 😊

@webdeb
Copy link

webdeb commented Mar 5, 2019

@marvinhagemeister 🎉

@marvinhagemeister marvinhagemeister mentioned this pull request Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@reznord reznord reznord approved these changes

@hassanbazzi hassanbazzi hassanbazzi approved these changes

@BartWaardenburg BartWaardenburg BartWaardenburg approved these changes

@andrewiggins andrewiggins andrewiggins approved these changes

@developit developit developit approved these changes

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.