Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size optimizations #1316

Merged
merged 9 commits into from
Mar 4, 2019
Merged

Size optimizations #1316

merged 9 commits into from
Mar 4, 2019

Conversation

developit
Copy link
Member

@developit developit commented Mar 4, 2019 •
edited
Loading

Note: these depend on developit/microbundle#335 for additional size benefits.

cristianbote
cristianbote approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@coveralls
Copy link

coveralls commented Mar 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling cc431b2 on size-optimizations into d5d42d7 on master.

marvinhagemeister
marvinhagemeister approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@marvinhagemeister marvinhagemeister merged commit 546f999 into master Mar 4, 2019
@JoviDeCroock JoviDeCroock deleted the size-optimizations branch October 10, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianbote cristianbote cristianbote approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@developit @coveralls @marvinhagemeister @cristianbote