Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin rendering with diff instead of diffChildren and other golf ⛳ #1715

Merged
merged 11 commits into from
Jun 18, 2019

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Jun 14, 2019

Beginning the render with diff means that the initial Fragment will be rendered as a real Component making our parent._children pointer more useful (will have meaningful _dom pointers, will have forceUpdate function after initial render).

Total change: -12 B

@coveralls
Copy link

coveralls commented Jun 15, 2019

Coverage Status

Coverage decreased (-0.1%) to 99.674% when pulling e4bde0c on enter-the-diff into f848a03 on master.

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, I just hadn't had the same conclusion about hooks yet, In my opinion that should be evaluated in another PR. For the rest this looks really alike what I had. Good work Andre

@andrewiggins
Copy link
Member Author

Coveralls is failing cuz I skipped two tests in debug cuz the implementation doesn't work as expected. Let's fix that debug feature in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants