-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin rendering with diff instead of diffChildren and other golf ⛳ #1715
Conversation
Since this search is only invoked right after we have created a new excessDomChildren list (render.js and diffElementNodes), we don't need to worry about null entires in the excessDomChildren list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, I just hadn't had the same conclusion about hooks yet, In my opinion that should be evaluated in another PR. For the rest this looks really alike what I had. Good work Andre
Coveralls is failing cuz I skipped two tests in debug cuz the implementation doesn't work as expected. Let's fix that debug feature in a separate PR. |
Beginning the render with diff means that the initial Fragment will be rendered as a real Component making our
parent._children
pointer more useful (will have meaningful_dom
pointers, will haveforceUpdate
function after initial render).Total change: -12 B